fix(gradle/plugin): reset kotlin SourceDirectorySet classesDirectory - #1926
Open
guilhas07 wants to merge 1 commit into
Open
fix(gradle/plugin): reset kotlin SourceDirectorySet classesDirectory#1926guilhas07 wants to merge 1 commit into
guilhas07 wants to merge 1 commit into
Conversation
Problem: Kotlin Gradle Plugin binds SourceDirectorySet classesDirectory to compileKotlin.destinationDirectory via `SDS.compiledBy(compileKotlin, ::destinationDirectory)`. The JVM jar task consumes: - sourceSet.output.classesDirs, which tracks SDS.destinationDirectory (kotlin/main) - SDS.classesDirectory, which tracks compileKotlin.destinationDirectory (overwritten by byteBuddyKotlin to kotlinByteBuddyRaw). This results in the jar having duplicated entries for every kotlin class. Solution: Reset SDS.classesDirectory from compileKotlin.destinationDirectory to byteBuddyKotlin.target (kotlin/main).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Kotlin Gradle Plugin binds SourceDirectorySet classesDirectory to compileKotlin.destinationDirectory via
SDS.compiledBy(compileKotlin, ::destinationDirectory). The JVM jar task consumes:This results in the jar having duplicated entries for every kotlin class.
Solution:
Reset SDS.classesDirectory from compileKotlin.destinationDirectory to byteBuddyKotlin.target (kotlin/main).
I believe I've missed this before because I had
duplicatesStrategy = EXCLUDEon the jar task (a leftover from when I tried to create the task "by hand"), which silently dropped the duplicate entries and hid this bug.